fix(toast): raise sidebar toast placement#5420
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ComputelessComputer
force-pushed
the
fix/sidebar-toast-position
branch
2 times, most recently
from
c381bbe to
402d28e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 402d28e. Configure here.
Move the upgrade toast higher when the left sidebar timeline is active and cover the placement behavior with focused tests.
ComputelessComputer
force-pushed
the
fix/sidebar-toast-position
branch
from
402d28e to
944d462
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the upgrade toast higher when the left sidebar timeline is active and cover the placement behavior with focused tests.
Note
Low Risk
UI-only toast positioning and tests; no auth, data, or API changes.
Overview
When the left sidebar timeline is expanded, the main shell now passes
placement="left-sidebar"toToastAreainstead of always using the default layout.ToastAreagains an optionalplacementprop and moves toast positioning from the fixedtop-14class to explicitleft/topstyles. In left-sidebar mode it centers horizontally on the main chat surface ([data-chat-floating-anchor]) and sits slightly below its top edge, updating on resize, scroll, and ResizeObserver. Default mode keeps the prior top-timeline behavior (calc(50% + offset)and 56px top). Collapsed sidebar timeline still uses default placement.New unit tests cover shell placement wiring and toast position behavior (default, anchored, scroll, and fallback when placement changes).
Reviewed by Cursor Bugbot for commit 944d462. Bugbot is set up for automated code reviews on this repo. Configure here.